Should I upgrade the RAM on my 2012 non-retina MacBook Pro?

Yes, upgrade the RAM if you already have an SSD. The 2012 non-retina MacBook Pro is a tank, but its biggest crime in 2024 is that spinning hard drive. If you haven’t swapped that for an SSD yet, do that first.