How should I treat metal staining in my pool?

Use a metal sequestrant instead of shocking with chlorine. Chlorine oxidizes dissolved metals into solid stains, while a sequestrant binds them so they stay dissolved. For existing stains, lower pH to 7.0, apply ascorbic acid, brush, circulate, then add sequestrant. Prevent future issues by testing fill water and avoiding copper-based algaecides.