Does FileVault significantly slow down modern Macs?

No, not significantly — especially on Apple Silicon Macs or Intel models with a T2 chip (2018+). These have dedicated hardware encryption accelerators, so you won’t notice any slowdown in daily use. The only exception is during initial encryption, which takes a few hours, and on older pre-2018 Intel Macs there can be a slight hit during heavy disk writes.