Can I get a discount at NYC attractions just for being a New York resident?

Probably not. Most major NYC attractions have phased out general resident discounts. The Discovery Pass is a bundled ticket deal, not a local discount. Your best bet is library passes, membership reciprocity, or free admission days. Don’t assume — check their website before you go.